[Sdk-public] Patch Review: kernel/classes/ezrssexport.php

[Alberto Mucignat]

hi all

I reported this as a bug, days ago:

http://ez.no/community/bugs/rss_2_0_export_fail_on_validation

bye, alberto.



Jan Borsodi wrote:

>On Monday 5. December 2005 00:17, kracker wrote:
>  
>
>>Greetings,
>>
>>Today I took a look at a bug in the rss export format which came up to
>>the foreground today for me.
>>
>>Basically there is a bug in the rss export which causes the resulting
>>rss feeds to not conform to the rss specification where a single space
>>is omitted between the `date` and `GMT`.
>>
>>This patch adds the space needed. The patch is a fairly small fix but
>>definitely solves the problem (which has been around for quite a
>>while)
>>
>>I am looking to see if anyone has a problem with this being committed to
>>trunk.
>>    
>>
>
>I checked the spec for the RSS, specifically the RFC822 for the dates and 
>there should be no space between the two items.
>But it seems most implementations have the space there so we should do the 
>same. so I say go for being added to trunk (and stable branches), just fix 
>the issue I mention below.
>
>  
>
>>Bug: http://ez.no/community/bugs/rss_2_0_feed_issue_with_pubdate
>>File: kernel/classes/ezrssexport.php
>>Commit message:
>>"Fixed bug #6420: RSS 2.0 feed : issue with PubDate."
>>kernel/classes/ezrssexport.php
>>
>>Diff:
>>
>>svn diff kernel/classes/ezrssexport.php
>>Index: kernel/classes/ezrssexport.php
>>===================================================================
>>--- kernel/classes/ezrssexport.php      (revision 14251)
>>+++ kernel/classes/ezrssexport.php      (working copy)
>>@@ -555,7 +555,7 @@
>>             $item = $doc->createElementNode( 'item' );
>>
>>             unset( $itemPubDate );
>>-            $itemPubDate = $doc->createElementTextNode( 'pubDate',
>>gmdate( 'D, d M Y H:i:s', $object->attribute( 'published' ) ) .'GMT' );
>>+            $itemPubDate = $doc->createElementTextNode( 'pubDate',
>>gmdate( 'D, d M Y H:i:s', $object->attribute( 'published' ) ) .' '.'GMT' );
>>    
>>
>
>Just one thing, please combine the two strings together, ie. don't do:
>.' '.'GMT'
>but do:
> . ' GMT' );
>
>  
>


-- 
Alberto Mucignat
Direttore IT
ProDigi - StudentiMediaGroup SpA
http://www.prodigiweb.it
via F. Nardini 1/C
000162 Roma
Off +39 06 87420632
Fax +39 06 87420644
Mob +39 349 3517720
Skype alberto.mucignat
---
This communication contains information which is confidential 
and may also be privileged. It is for the exclusive use of the
intended recipient(s). If you are not the intended recipient(s),
please note that any distribution, copying or use of this 
communication or the information in it is strictly prohibited.
If you have received this communication in error, please notify
the sender immediately and then destroy any copies of it.